Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix megalinter json parsing #458

Merged
merged 2 commits into from
Sep 4, 2024
Merged

feat: fix megalinter json parsing #458

merged 2 commits into from
Sep 4, 2024

Conversation

beqaabu
Copy link
Contributor

@beqaabu beqaabu commented Sep 2, 2024

Description of proposed changes


Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@beqaabu beqaabu requested a review from a team as a code owner September 2, 2024 16:11
@beqaabu beqaabu requested review from Retamogordo and mostafaesmaeilli and removed request for a team, Retamogordo and mostafaesmaeilli September 2, 2024 16:11
@atodorov atodorov merged commit 93c5c88 into dev Sep 4, 2024
49 of 56 checks passed
@atodorov atodorov deleted the empty-mainnet-spec branch September 4, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants